| Age | Commit message (Collapse) | Author | Files | Lines |
|---|
|
|
|
|
|
|
|
|
|
|
|
This removes the function pointer interface which was adding
needless complexity and making it difficult to add new events. Now
if new events are only meant for lua they only need to be added to
the lua interface. This will also have a minor reduction in
runtime memory usage and produce a smaller binary.
The only runtime difference is that QUIT happens after all windows
have been closed and their files freed.
|
|
|
|
Change the file displayed in a window by writing the new file name
to the window's file member.
This is useful to change the displayed file during events.
Using the edit command during an event caused by a pervious edit
command causes a double free.
|
|
This allows better control over styling, as well as potential for
entirely new UI elements implemented entirely using the Lua API.
|
|
The old style handling had a lot edge cases where one of the
colours or the attribute wouldn't get applied correctly. This
commit adds a new style_set() method to the Ui which should be
called instead of manually touching a cell's style. This also
means that the Cell struct can be made opaque since all the
handling is now done inside the ui-terminal files.
With this it is now viable to combine the light and dark 16 colour
themes into a single base-16 theme. This theme works very well
with the Linux virtual console and will now be the default theme
regardless of if the terminal supports 256 colours or not. This
should address the common complaints about vis not respecting the
users default terminal colours.
fixes #1151: Theming is sometimes partially applied or ignored
see #1103: terminal no longer has transparency/opacity
see #1040: Transparent background and setting options by default
|
|
Silencing compiler's -Wparentheses warning.
|
|
fixes #1151 (part 2): Set foreground color for matching pair
|
|
fixes #1151: Set foreground color for visual selection
|
|
according to POSIX wait(3p) the return status needs to be checked
and the macro WEXITSTATUS(stat_val) should be used to get the actual
return value on a normal exit. POSIX doesn't specify the value of
stat_val on abnormal exit and thus vis_pipe() should just return
-1 as it does for other errors
closes #1130: vis:pipe returns wrong exit status (when non-zero)
Thanks @pippi1otta for the report and suggestion.
|
|
|
|
|
|
Rationale
A modern text editor usually includes tools for helping user
to avoid mistakes in texts. Those tools include spell checkers and
programming language integrations. Though vis explicitly states
that the full featured IDE is not a goal, implementing some of
the tools might be achieved using its Lua API. Unfortunatelly
the API misses the ability to start a process and to perform
a communication with it without completely blocking the editor UI,
which is crucial for any tool that performs background tracking of
the inserted text (e. g. language servers).
Implementation details
New feature introduces new API method: communicate. The method
start a new process and returns a handle to communicate with
the process instantly. The patch inserts stderr and stdout
file descriptors of the process to the pselect call of the main loop
used for reading user input to track the process state without
blocking the main loop until the process is finished.
Any changes in the process state cause the iteration of the main loop
and are being exposed to the Lua API as new event: PROCESS_RESPONSE.
|
|
Reading from curs_refresh(3X) from curses, calling doupdate() repeatedly
will cause 'several bursts of output to the screen'. wnoutrefresh() has
the smarts to only copy the changed lines to the copied virtual screen,
but doupdate() does not.
There have been several bug reports related to flickering but all seems
to be inconsistenly reproducible due to different terminal buffering
behavior. See #1032, #327
Unfortunately, when I am using a slow display, I still notice
flickering, so this commit changes the routines for opening new windows
and splitting windows to wait until the last change is finished before
calling doupdate().
|
|
This enables restoring the terminal from a fullscreen command like
curses based program. Use cases are e.g. a file picker based on some
external program like nnn (https://github.com/jarun/nnn).
|
|
|
|
|
|
|
|
|
|
|
|
Once we have written all data we should properly close the (correct)
pipe. Before we wrongly closed the pipe connected to the standard output
stream.
More generally, we currently do not listen for child process termination,
but instead wait until all the connected pipes are closed. This might
be problematic in case the external process keeps hold of the standard
I/O file descriptors. One particular example of this is wl-copy(1).
See #929
|
|
|
|
There are two main ways how the input queue is managed in vis:
- vis_keys_feed(..) appends new input to the queue and immediately
starts processing it. Starting from the position before the call
i.e. ignoring any previously queued input.
This is typically used in key binding handlers where the input
queue still contains the mapping leading to the invocation of the
handler. In that case new input should be interpreted immediately,
before the handler eventually returns and its mapping is consumed.
- vis_keys_push(..) with pos=0, appends new input to the end of the
queue and starts processing it from the start of the queue, taking
the full content into consideration.
This is used by the main loop when new input becomes available.
This patch switches the handling of <C-c> after a SIGINT from the former
to the latter mechanism and fixes mappings using <C-c> in a non-leading
position.
|
|
|
|
Add a global ignorecase boolean option. When set add REG_ICASE to cflags
when calling text_regex_compile().
|
|
|
|
|
|
Not sure why we need to allocate space for an additional character.
This also avoids creating out of bound pointers.
|
|
|
|
eg. if your long line is a comment with green fg, and you set your
column color bg red while not specifying the fg, then the result is
green fg on red bg.
Prior to this change the result would be default fg on red bg, thus
one char in the long line of green text would look odd/wrong.
Of course if you do explicitly set the column color fg to default in your
theme then the result will not be what you expect - ideally we need
an UNSPECIFIED color type instead of relying on DEFAULT.
|
|
|
|
|
|
|
|
The core vis code was originally written under the assumption that there
always exists at least one window. However, when being called from the
Lua configuration file during start up this is not yet the case.
In general, Lua code should always be placed within appropriate event
handlers e.g. vis.events.INIT for global configuration. Invoking API
functions depending on an active window from top level statements is
not supported. Where before the editor simply crashed, these changes
turn such code sections into NOPs.
Fix #561
|
|
Special case <C-v><Enter> to still insert a carriage return as discussed
in #656 and changed in 2cfc9c867bdfd4cc3ae3246f31cf636633fe1a5f.
Due to limitations of the current implementation <C-v> is not generic,
i.e. combining it as r<C-v><Enter> will not work.
Fixes #765
|
|
|
|
|
|
Check for end-of-text.
|
|
Valid values are `read`, `mmap` or `auto`.
|
|
|
|
Fix #656
|
|
When the fore and background colors are the same, swapping them has
no effect. Instead use the specified cell attributes. Previously the
CELL_ATTR_REVERSE used in the default selection style was ignored.
In general the default style definitions for non-Lua builds could
probably be improved further.
Fix #635
|
|
Previously `ci<` would have no immediate effect because in operator
pending mode `i<` was wrongly treated as a powwible prefix of `i<Tab>`.
Fix #624
|
|
Use visual mode and :| to filter text through external commands.
The mapping was already reused for selection complement.
|
|
In practice this was never an issue also it is guaranteed that the
terminating zero byte is already there.
Fixes coverity issue 157023.
|
|
This should make it easier to see which window is focused.
|
