From 1bfe132a81adddd33e078583f4198d8d8cb31d57 Mon Sep 17 00:00:00 2001 From: Randy Palamar Date: Mon, 9 Oct 2023 23:17:40 -0600 Subject: revert c22b2c2 & 364d212 aka: "check for EOF before unsetting row, col & line cache in view_coord_get" "fix bug where visual-line selections after view were considered visible" These commits have created more bugs then they fix. Reverting them reintroduces #1074: Slave selection strangled by view cliff. Fixes #1143: Disappearing selection --- CHANGELOG.md | 1 - view.c | 3 +-- 2 files changed, 1 insertion(+), 3 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index e52e195..5967a31 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -6,7 +6,6 @@ - fix a ~ being considered a special character in path patterns (except at the start) - improvements to and clean-up of vis-open - add Selection:remove() to lua API -- fix bug where visual-line selections after view were considered visible - don't set `_FORTIFY_SOURCE` in configure - update dockerfile to alpine 3.18 diff --git a/view.c b/view.c index 5fa512b..2b06286 100644 --- a/view.c +++ b/view.c @@ -330,8 +330,7 @@ bool view_coord_get(View *view, size_t pos, Line **retline, int *retrow, int *re size_t cur = view->start; Line *line = view->topline; - bool eof = view->end == text_size(view->text); - if (pos < view->start || (pos >= view->end && !eof)) { + if (pos < view->start || pos > view->end) { if (retline) *retline = NULL; if (retrow) *retrow = -1; if (retcol) *retcol = -1; -- cgit v1.2.3