aboutsummaryrefslogtreecommitdiff
AgeCommit message (Collapse)AuthorFilesLines
2021-10-06contrib: make layout.py more pythonicMichal Siedlaczek1-22/+19
2021-10-06contrib: add python layoutLeon Henrik Plickat1-0/+142
2021-10-04docs: change Enter to ReturnEuro201791-2/+2
xkbcommon uses `Return` to indicate this key, `Enter` isn't a valid keysym name. Co-authored-by: Euro <no>
2021-10-04Decrease layout demand timeout to 100msLeon Henrik Plickat1-1/+1
Layout generators are generally pretty fast. The timeout is only reached when the generator is faulty / stuck. In that case, freezing for 1 second is simply bad UX.
2021-10-02Server: fix use after free in deinit()Isaac Freund1-1/+1
The input manager and seats must be destroyed before the display is destroyed as they need to destroy their timer event sources used for key repeat.
2021-10-02View: fix unmap/destroy control flowIsaac Freund12-68/+64
Currently the view destruction sequence is started as soon as a view is unmapped. However, this is incorrect as a client may map the view again instead of destroying it. Instead, only start the view destruction sequence when the underlying xdg toplevel or xwayland surface is destroyed.
2021-10-02doc: update my (Isaac's) email addressIsaac Freund3-3/+3
2021-10-02View: add fullscreen check missing in previous commitIsaac Freund1-7/+9
2021-09-30View: resize if moved between outputs while fullscreenIsaac Freund1-0/+7
2021-09-30Subsurface: remove commit listener in destroy()Isaac Freund1-0/+2
Currently if destroy() is called while a subsurface is mapped a dangling commit listener is left behind. This is obivously a problem, so check if the subsurface is mapped in destroy() and remove the listener if needed.
2021-09-27ci: fix xbps invocationIsaac Freund1-6/+6
This avoids errors like: util-linux-common-2.37.2_1 in transaction breaks installed pkg `libfdisk-2.37.1_1' util-linux-common-2.37.2_1 in transaction breaks installed pkg `libsmartcols-2.37.1_1' libuuid-2.37.2_1 in transaction breaks installed pkg `libfdisk-2.37.1_1' libuuid-2.37.2_1 in transaction breaks installed pkg `util-linux-2.37.1_1' libblkid-2.37.2_1 in transaction breaks installed pkg `libfdisk-2.37.1_1' libblkid-2.37.2_1 in transaction breaks installed pkg `util-linux-2.37.1_1' libmount-2.37.2_1 in transaction breaks installed pkg `util-linux-2.37.1_1' Transaction aborted due to unresolved dependencies.
2021-09-27Cursor: implement surfaceAt() for XwaylandUnmanagedIsaac Freund1-6/+19
2021-09-18xdg-toplevel: fix configure serial checkingIsaac Freund2-7/+26
Currently if another configure is in flight after the one we are tracking the serial of and the client acks the second configure as well (or only the second configure) before committing, we will never realize the configure we are tracking has been acked. Instead, listen for the ack_configure signal and set a bool that we can check on surface commit. This probably isn't an issue that would actually be hit by well behaved clients as river doesn't send redundant configure events. However, having correct code is always better even if it's slightly more complex.
2021-09-16command: Use std.ComptimeStringMap to get impl. function from command stringLeon Henrik Plickat1-57/+52
2021-09-14river: add send-to-previous-tags commandPeter Rice6-0/+24
2021-09-07river: Allow applying CSD based on window titlesBen Fiedler6-34/+80
This extends the `csd-filter-add` command to allow matching on window titles as well, using a `csd-filter-add kind pattern` syntax. The following kinds are supported: * `title`, which matches window titles * `app-id`, which matches app ids Only exact matches are considered. As an example following configuration applies client-side decorations to all windows with the title 'asdf with spaces'. riverctl csd-filter-add title 'asdf with spaces'
2021-09-06river: fix viewporter protocol implementationIsaac Freund2-12/+27
It turns out that wlroots requires us to do a bit more than just create the wlr_viewporter. Docs are being added to the wlroots header in https://github.com/swaywm/wlroots/pull/3171
2021-09-06river: Fix errdefer in floatFilterAddBen Fiedler1-1/+1
2021-09-06docs: update example init for float fitler changesIsaac Freund1-3/+3
2021-09-06river: Allow floating based on window titlesBen Fiedler5-38/+71
This extends the `float-filter-add` command to allow matching on window titles as well, using a `float-filter-add kind pattern` syntax. The following kinds are supported: * `title`, which matches window titles * `app-id`, which matches app ids Only exact matches are considered. As an example following configuration floats all windows with the title 'asdf with spaces'. riverctl float-filter-add title 'asdf with spaces'
2021-08-19river: implement xdg-activation-v1novakane18-6/+104
- add a new "urgent" border color - add a new event to river-status-unstable-v1 Co-authored-by: Isaac Freund <ifreund@ifreund.xyz>
2021-08-18docs: default keyboard mapping mode is "normal"Keith Hubbard1-2/+2
2021-08-15command: support repeating keyboard mappingsKeith Hubbard9-22/+92
Repeating mappings are created using the -repeat option to the map command: % riverctl map normal $mod+Mod1 K -repeat move up 10 - repeating is only supported for key press (not -release) mappings - unlike -release, -repeat does not create distinct mappings: mapping a key with -repeat will replace an existing bare mapping and vice-versa Resolves #306
2021-08-12river-status: fix output status destructionIsaac Freund2-2/+10
There was a use-after-free if the Output was destroyed first, and the memory of the output status was leaked.
2021-08-12output: simplify layer shell handling on destroyIsaac Freund1-9/+7
No need for noop output hacks here, wlr.LayerSurfaceV1.close() synchronously emits the unmap signal if the layer surface is mapped.
2021-08-12layer-shell: ignore commits on closed layer surfaceIsaac Freund1-0/+3
2021-08-10seat: always add view to focus stack on mapIsaac Freund5-41/+31
Currently if a view is mapped while some other view is fullscreen, it will not be added to the focus stack, which means that if the fullscreen view is then closed the view which was not added to the focus stack will not be focused. To fix this, always add views to the focus stack on map.
2021-08-09config: fix leak of default layout namespaceIsaac Freund1-0/+3
2021-08-09Xwayland: fix possible use-after-free on unmapIsaac Freund1-2/+2
The view.unmap() call may synchronously destroy the view, which makes the the code removing listeners which is currently run after view.unmap() access free'd memory. To fix this, simply change the order of the calls to match that of XdgToplevel.handleUnmap().
2021-08-07render: draw borders before rendering viewsKeith Hubbard1-4/+4
Menus, tooltips, etc. can extend beyond a view's borders. Render views after their borders so floating content appears on top. Unfocused floating content can still be obscured by views higher in the stack and the focused view.
2021-08-02river: fix crash on disabling all outputsIsaac Freund1-8/+10
If using the on-output-change cursor warp option river currently crashes when the last real output is disabled as the noop output used as a fallback is not present in the output layout.
2021-08-02river-layout: fix typo in protocolIsaac Freund1-3/+3
2021-07-31util: remove unused functionIsaac Freund1-10/+0
2021-07-29completions: Remove strict in focus-follows-cursornovakane3-3/+3
2021-07-29cursor: remove strict focus-follows-cursor modeIsaac Freund3-8/+3
This is pretty much unusable after recent improvements to the cursor code, and was totally broken causing a stack overflow as soon as the cursor was moved over any surface until the previous commit. Furthermore, none of the core contributors or people active on IRC seem to use it.
2021-07-29cursor: fix crash if focus-follows-cursor is setIsaac Freund1-3/+5
Currently we hit a stack overflow as we do not check if the target view already has keyboard focus before calling Seat.focus() in Cursor.passthrough(). To fix this, simply add this check.
2021-07-28build: Use pkg-config to handle river protocolsnovakane1-1/+20
2021-07-28river: properly teardown surface treeIsaac Freund5-45/+95
When an xdg toplevel, layer surface, etc is destroyed, it is not guaranteed that all the children in the surface tree have already been destroyed. If there are still children around, destroying the root of the tree would leave dangling pointers. To fix this, destroy all children when destroying any node in the tree.
2021-07-28output: fix debug log on tag changeIsaac Freund2-8/+6
2021-07-27docs: fix typo in rivertile man pageRafael Escobar1-1/+1
2021-07-26config: change color format to 0xRRGGBBAAIsaac Freund5-12/+19
The current format of #RRGGBBAA is problematic as # starts a comment in POSIX compliant shells, requiring escaping/quoting and increasing complexity. This is a breaking change.
2021-07-26docs: Wayland should always be capitalizedIsaac Freund2-5/+5
This matches the style used on https://wayland.freedesktop.org/
2021-07-25view: arrange when exiting fullscreen to layoutIsaac Freund3-26/+20
This arrange is actually required because the post_fullscreen box might not hold the correct dimensions if the view was made fullscreen while a transaction was already in progress.
2021-07-25view: ensure saved buffers are always droppedIsaac Freund1-0/+5
Currently if a view is moved from layout to fullscreen while a transaction involving that view is in progress the saved buffers are not dropped, which causes stale state to be rendered.
2021-07-25layout: assert output state matches layout appliedIsaac Freund1-2/+3
This is guaranteed to already be set to the layout being committed. It is set either when a client binds a new layout object or when the user changes the layout namespace in use.
2021-07-25build: install river-layout-v3 to $PREFIX/share/riverIsaac Freund1-12/+5
This makes it easier for other projects (i.e. everyone's layout generators) to depend on the protocol xml without needing to vendor it. The river-layout-v3 protocol should remain stable for the forseeable future, hopefully forever. On the other hand, the current river-control-unstable-v1 and river-status-unstable-v1 protocols will be replaced as soon as we have time to implement better versions. Therefore, let's not encourage usage of the protocols we intend to remove.
2021-07-25build: remove example river-status clientIsaac Freund2-112/+0
This is out of date and currently doesn't compile. It also doesn't really belong in the repository IMO, except maybe in the contrib folder.
2021-07-25river: improve new layer surface log formattingIsaac Freund1-3/+3
2021-07-25river: add custom wlroots log handlerIsaac Freund3-1/+54
This makes river's log output more consistent and will allow filtering by the wlroots scope in the future.
2021-07-24river: simplify log levels exposed to the userIsaac Freund2-22/+57
You can read more about the author.