aboutsummaryrefslogtreecommitdiff
AgeCommit message (Collapse)AuthorFilesLines
2023-03-25command/send-to-output: add -current-tags flagPablo Ovelleiro Corral2-4/+18
2023-03-24Server: remove debug leftovertiosgz1-2/+0
2023-03-24session-lock: fix assertion failures and clean upIsaac Freund3-21/+21
The removed assertions aren't possible to guarantee due to the fact that the lock render state is updated asynchronously as the output is rendered.
2023-03-16LayerSurface: fix surfaces on multiple outputs at onceIsaac Freund1-5/+10
The previous commit broke handling of keyboard interactive layer surfaces being created on multiple outputs at once. This new approach reverts part of the logic change in the previous commit while keeping the fix for the crash and the new assertion.
2023-03-16LayerSurface: handle focus when switching outputsIsaac Freund2-3/+1
Currently if a layer surface is focused and the user focuses a different output the layer surface remains focused. However, updating focus on layer surface unmap only considers seats that have the layer surface's output focused. To fix this there are 3 approaches I see: 1. Unfocus all layer surfaces on the old output when switching output focus, focus any layer surfaces on the new output. 2. Disallow switching output focus while a layer surface is focused. 3. Stop caring about output focus when determining which layer surface should gain/lose focus. I've taken the 3rd option here as it is significantly simpler to implement and maintain but still feels reasonably intuitive.
2023-03-15build: work around zig 0.10.0 bug to fix CIIsaac Freund1-10/+15
2023-03-15Cursor: apply x/y change during resize on commitIsaac Freund4-68/+139
This fixes issues with resizing clients that stick to a fixed aspect ratio during resize such as mpv.
2023-03-14Cursor: lock to current geometry during move/resizeIsaac Freund2-50/+47
This eliminates cursor jitter entirely during interactive resize. This also fixes a bug where the xdg-toplevel resizing state was not cleared if a resize operation was aborted due to a change in view tags or similar.
2023-03-14XdgToplevel: ensure view dimensions match geometryIsaac Freund2-6/+26
Some clients (e.g. mpv) do not respond to configures by committing buffers of the exact size requested. Instead they may commit a buffer of a smaller size in order to maintain an aspect ratio or not commit a buffer at all.
2023-03-14Cursor: fix warp on output change with no viewsIsaac Freund1-0/+4
2023-03-14Root: separate fallback list to handle 0 outputsIsaac Freund1-10/+40
Mixing views that are currently being mapped/unmapped with views that are stashed during hotplug down to 0 outputs is error-prone and almost certainly has a bug or two hiding currently.
2023-03-14Root: remove incorrect assertions in addOutput()Isaac Freund1-2/+0
2023-03-14Output: reinitialize output_status, cleanupIsaac Freund2-7/+13
If a output is removed and added back without being destroyed this must be reinitialized. This commit also cleans up the Root.applyPending() calls related to output hotplug and adds some more logging.
2023-03-13doc: fix typo in riverctl man pageIsaac Freund1-1/+1
2023-03-12example/init: update for rules systemIsaac Freund1-5/+4
2023-03-12docs: fix typo in riverctl man pageIsaac Freund1-4/+4
2023-03-12river: add rules systemIsaac Freund17-271/+662
This is a breaking change and replaces the previous csd-filter-add/remove and float-filter-add/remove commands. See the riverctl(1) man page for documentation on the new system.
2023-03-10xdg-decoration: clean up implementationIsaac Freund11-153/+156
We now send some protocol errors that wlroots 0.16 is missing [1]. This also allows us to access the xdg decoration from a view, which will be necessary for some future changes. [1]: https://gitlab.freedesktop.org/wlroots/wlroots/-/merge_requests/4051
2023-03-10View: add `none` impl tag for better safety checksIsaac Freund3-2/+22
2023-03-10xdg-shell: determine tiled state by float stateIsaac Freund1-8/+12
How river currently sets this isn't really in accordance with the spirit of the protocol. It was originally done this way to get gtk3 windows to look a little bit better with borders drawn around them. However, I've come to believe that river shouldn't just ignore standards like this. The right way to do things would be to either implement the xdg-decoration protocol for gtk properly or to be pragmatic and accept some programs are intended to be used with CSD and that's OK.
2023-03-09example/init: Fix confusing commentsIsaac Freund1-2/+2
River does not currently recognize Ctrl as a modifier, only Control.
2023-03-09river-status: only send layout name if changedIsaac Freund1-7/+12
2023-03-08XdgToplevel: clean up wlr_surface data on destroyIsaac Freund1-0/+3
2023-03-08Xwayland: eliminate unneeded user data usageIsaac Freund2-3/+0
This is some dead code that is left over from before the scene graph changes.
2023-03-07layer-shell: apply exclusive zones in separate passIsaac Freund1-7/+23
This brings the behavior closer to what we had before the scene graph refactor. The main difference now is that the order has changed from background to overlay instead of from overlay to background. This ordering seems to make more sense in the cases I've tested and the old ordering was just cargo-cult anyways.
2023-03-06Seat: fix potential assertion failureIsaac Freund1-1/+3
2023-03-06river: improve comments on pending/inflight/currentIsaac Freund2-4/+15
2023-03-06wlr-foreign-toplevel-management: implement protocolIsaac Freund3-4/+139
Well, at least as much of it as was implemented before the scene graph refactor.
2023-03-06Xwayland: only raise views if activatedIsaac Freund1-1/+3
2023-03-05pointer-constraints: implement protocolIsaac Freund7-43/+335
Now with 50% less pointer warping! The new implementation requires the user to move the cursor into the constraint region before the constraint is activated in order to keep behavior more predictable.
2023-03-05Seat: use the grab aware API to clear focusIsaac Freund1-1/+1
This looks to be a typo made way back in the early days of river.
2023-03-05Cursor: use pending position to warp during moveIsaac Freund1-2/+2
2023-03-04presentation-time: support protocolIsaac Freund1-0/+3
2023-03-04Server: remove headless backendIsaac Freund1-5/+0
This was previously used to create a noop output, but we no longer rely on that hack.
2023-03-04SceneNodeData: allow access from wlr_surfacesIsaac Freund11-53/+80
This replaces the old View.fromWlrSurface function and is more general. This commit also moves the xdg activation request_activate listener to Server as it has no reason to be in View.
2023-03-04river: clean up some uneeded TODOsIsaac Freund4-9/+0
2023-03-04river: fix a few leaksIsaac Freund4-0/+8
2023-03-04Cursor: store offset and warp cursor during moveIsaac Freund1-4/+17
This is more reliable since it uses absolute coordinates instead of a relative movement which could cause the cursor position to get out of sync with the view. This is the same approach used for resize.
2023-03-04View: rework configure abstractionIsaac Freund4-105/+110
- Move the decision whether a configure should be tracked or not into the xdg toplevel/xwayland code. - Only track configures for xdg toplevels with the transaction system if the dimensions of the view are affected.
2023-03-03xdg-shell: honor client move/resize requestsIsaac Freund2-1/+50
2023-03-03Cursor: allow resizing from all edgesIsaac Freund1-45/+157
Co-authored-by: Leon Henrik Plickat <leonhenrik.plickat@stud.uni-goettingen.de>
2023-03-03deps: update zig-wlroots to fix Xwayland crashIsaac Freund2-2/+2
2023-03-03Xwayland: hide override redirect windows if lockedIsaac Freund1-0/+11
2023-03-03Root: keep all fullscreen views the correct sizeIsaac Freund3-41/+16
Currently we may resize fullscreen views when they become visible/not visible when switching tags even if their fullscreen state remains constant. This is suboptimal, and as it turns out also much more complex to implement.
2023-03-02XdgToplevel: fix size_changed check on commitIsaac Freund1-16/+18
We need to initialize the geometry on map to ensure the first commit is handled correctly. Also we don't care about the x/y of the geometry, only the width/height.
2023-03-02Xwayland: fix has_fixed_size heuristic for floatingIsaac Freund1-1/+2
2023-03-02View: handle destroy during inflight layout demandIsaac Freund4-47/+39
2023-03-02river: render floating views above the layoutIsaac Freund2-5/+20
2023-03-01View: fix frame perfection on unmapIsaac Freund2-3/+15
2023-03-01View: only send configures through transactionsIsaac Freund7-82/+39
This reduces the number of separate configure events sent to clients through better batching and is also more correct.
You can read more about the author.