aboutsummaryrefslogtreecommitdiff
AgeCommit message (Collapse)AuthorFilesLines
2023-03-01Root: centralize focus(null) calls in applyPending()Isaac Freund11-39/+21
2023-02-28csd-filter-add/remove: add missing applyPending()Isaac Freund1-0/+2
A transaction is now necessary to update border state.
2023-02-28river: fix various fullscreen related bugsIsaac Freund5-87/+111
2023-02-28LayerSurface: fix use-after-free on destroyIsaac Freund4-10/+12
The scene_layer_surface may be destroyed before handleDestroy is called, which means we can't rely on it to access the wlr_layer_surface in destroyPopups().
2023-02-28OutputStatus: rework implementationIsaac Freund5-128/+147
This was motivated by the view tags not being proplerly updated by Root.commitTransaction() when there were no views on an output.
2023-02-28river: rework core data structures & transactionsIsaac Freund34-1537/+1021
2023-02-28View: use saved surface trees for transactionsIsaac Freund4-108/+86
2023-02-28Xwayland: render using the scene graphIsaac Freund6-59/+79
2023-02-28DragIcon: render using the scene graphIsaac Freund5-20/+99
2023-02-28xdg-shell: implement version 5Isaac Freund2-1/+3
2023-02-28XdgPopup: reimplement using the scene graphIsaac Freund7-10/+185
xdg-shell version 3 is now implemented, supporting popup repositioning.
2023-02-28LayerSurface: render using the scene graphIsaac Freund7-290/+152
This also brings a lot of code cleanup and proper support for version 4 of the protocol.
2023-02-28View: remove dead codeIsaac Freund1-18/+0
wl_output.enter/leave is handled by wlr_scene now.
2023-02-28Xwayland: create scene treeIsaac Freund1-2/+8
2023-02-28View: implement borders with scene graphIsaac Freund4-12/+56
2023-02-28Output: use separate scene trees for layersIsaac Freund6-20/+92
2023-02-28session-lock: use the scene graphIsaac Freund9-62/+135
2023-02-28Cursor: remove surfaceAt()Isaac Freund6-307/+152
We now use the wlr_scene API to find out what is at the cursor location.
2023-02-28render: use wlr_scene to render viewsIsaac Freund13-440/+77
2023-02-28wlr-foreign-toplevel-management: remove protocolIsaac Freund2-77/+2
This can be re implemented after the migration to the scene graph is complete.
2023-02-28render: remove damage trackingIsaac Freund14-503/+7
This will be handled by wlr_scene shortly.
2023-02-28pointer-constraints: remove protocolIsaac Freund5-207/+6
This implementation as it stands is incomplete/buggy and will make updating to wlr_scene more complex. It will be reimplemented after updating to wlr_scene is complete.
2023-02-28Keyboard: fix keyboard-layout mapping crashIsaac Freund1-1/+4
2023-02-27deps: update to latest zig-wayland/zig-wlrootsIsaac Freund2-0/+0
2023-02-27deps: update to latest zig-wayland/zig-wlrootsIsaac Freund3-1/+1
2023-02-10Seat: guard setFocusRaw() usage while lockedIsaac Freund2-0/+4
Focusing a layer shell or Xwayland override redirect surface while locked is a bug.
2023-02-03docs: remove repology badge from readmeIsaac Freund1-7/+3
It's getting too big and has too much redundant information.
2023-02-03docs: fix typos in riverctl man pageIsaac Freund1-6/+6
2023-01-30wlr-output-management: fix bug due to zig miscompilationIsaac Freund1-1/+1
It looks like having the empty error capture |_| on the else branch of the if statement causes the else branch to be ignored by the compiler. This should be a compile error, as the condition of the if statement is a bool, not an error union.
2023-01-25session-lock: fix assertion failure on hot-plug while lockedIsaac Freund1-1/+5
2023-01-24wlr-output-management: leverage new wlroots APIsIsaac Freund2-45/+18
These new functions allow testing commits without messing up the pending state of the output and needing to rollback. The new apply() function also makes the code considerably more concise.
2023-01-24wlr-output-management: apply adaptive sync stateAlexander Courtis1-0/+1
2023-01-21idle-inhibit: fix use-after-freeIsaac Freund1-1/+2
A user reported a crash that only reproduces when preloading a hardened malloc implementation. From the stack trace, this use-after-free seems to be the most likely cause. Yay hardened malloc!
2023-01-18session-lock: properly handle disabled outputsIsaac Freund2-0/+17
Outputs that are part of the layout but currently disabled (e.g. due to use of wlr-output-power-management) are not correctly handled as river currently waits for them to present a new locked frame before sending the locked event. This new frame never comes however since the output is disabled. Fix this by maintaining the correct Output.lock_render_state as outputs are enabled/disabled. Additionally add missing maybeLock() calls to handle the case that all outputs in the layout are disabled.
2023-01-13View: fix pointer comparison in notifyTitle()Hugo Machet1-2/+2
Curently since the struct is semantically passed by value not reference, there is no guarantee that the `seat_node.data.focused.view == &self` comparison will work as intended. Since updating to Zig 0.10.0, it seems this latent bug has now manifested and the focused view title is no longer sent to the client when it changes. Fix this by taking the view argument by constant pointer instead.
2023-01-13Cursor: fix incorrect lock manager state assertionZakariyya Von Forslun1-1/+1
2023-01-12command/layout: fix a memory leakIsaac Freund1-0/+2
2023-01-12Seat: rework Xwayland Override Redirect focusIsaac Freund4-63/+44
Instead of stashing the active view and setting Seat.focused to the Xwayland OR surface when a child OR surface of a currently focused Xwayland view is given keyboard focus, keep Seat.focused set to the Xwayland view. Such Override Redirect surfaces are commonly used for drop down menus and the like, and river should behave as if the parent Xwayland view still has focus. This ensures that the riverctl focus-view next/prev commands continue to work as expected while a popup is open, the correct focused view title will be sent over river status, etc. It's also cleaner to centralize this logic in XwaylandOverrideRedirect and keep it out of Seat.zig.
2023-01-12Seat: keep parent Xwayland view of a focused OR surface activatedZakariyya Von Forslun2-2/+44
Xwayland OR menus may disappear if their parent view is deactivated. The heuristic and ICCCM input model implemented prior, used to determine whether an OR surface may take focus, does not cover all menus, so retaining parent view activation works as a catch-all solution for handling unwanted OR menu focus.
2023-01-09deps: update zig-wayland to fix build on aarch64Isaac Freund1-0/+0
2023-01-08flags: further cleanup after Zig 0.10Isaac Freund4-13/+6
Long live the self hosted compiler!
2023-01-08deps: update to Zig 0.10Isaac Freund30-144/+77
2023-01-08render: fix rounding for fractional scalingIsaac Freund1-2/+2
We currently scale the width/height of rectangles based on the scaled x/y instead of the unscaled x/y. This however leads to inconsistent width/height due to rounding. Fix this bug by basing width/height scaling off of the original x/y. Furthermore, fix a typo where we scaled the height off of the x coordinate instead of the y coordinate.
2023-01-07session-lock: fix assertion failure on abnormal client behaviorIsaac Freund1-2/+4
If the client commits a protocol error or otherwise crashes before the session has been fully locked, we currently try to send the locked event without checking if the client has been destroyed. This commit adds the necessary if statement.
2023-01-07session-lock: fix assertion failure due to raceIsaac Freund2-5/+12
There's currently a potential race in the implementation that can be hit during unlocking. This is not a security vulnerability, but it does cause the compositor to crash due to a failed assertion. This commit simplifies the code and fixes the race as well as tightening up the assertions around this state/control flow even further.
2023-01-06session-lock: wait for present before lockingIsaac Freund3-4/+46
Currently we send the locked event after rendering and commit of blank or lock surfaces buffers on all outputs. However, this is technically not enough to ensure that the buffers have been presented. Instead, listen to the wlr_output present event to ensure that no normal, "unlocked" content is possibly visible.
2023-01-06rivertile: fix code to disallow 0 main countIsaac Freund2-10/+10
Also document this limit
2023-01-06render: premultiply alpha for user-provided colorsMaxVerevkin2-9/+11
The wlroots rendering API expects colors to be provided with premultipled alpha but we currently do not parse them as such. This causes blending with e.g. a transparent border color to be very broken.
2023-01-06completions: add keyboard-layoutLeon Henrik Plickat3-0/+3
2023-01-06ci: Use meson setup commandHugo Machet3-6/+6
Using `meson build` without `setup` have been deprecated, fix warning message: 'WARNING: Running the setup command as `meson [options]` instead of `meson setup [options]` is ambiguous and deprecated.
You can read more about the author.