vis: fix I/O redirection bugs, cleanup vis_pipe

The `:!` command did redirect stdout to a pipe which was used by
`vis-menu` to return the selected entry. However, this breaks
other interactive commands such as `:!/bin/sh` where command
output was never displayed. Instead we modified `vis-menu` to
re-open /dev/tty for its user interface which makes it work
as a regular filter `:|`

This patch also obsoletes the interactive flag previously passed
to the vis_pipe function. Interactive mode is instead enabled
by piping an invalid range.

1 files changed, 2 insertions, 2 deletions

diff --git a/register.c b/register.c
index a5f70ea..16a7233 100644
--- a/register.c
+++ b/register.c
@@ -29,7 +29,7 @@ const char *register_get(Vis *vis, Register *reg, size_t *len) {
 		buffer_init(&buferr);
 		buffer_clear(&reg->buf);
 
-		int status = vis_pipe(vis, &(Filerange){ .start = 0, .end = 0 }, false,
+		int status = vis_pipe(vis, &(Filerange){ .start = 0, .end = 0 },
 			(const char*[]){ VIS_CLIPBOARD, "--paste", NULL },
 			&reg->buf, read_buffer, &buferr, read_buffer);
 
@@ -70,7 +70,7 @@ bool register_put_range(Vis *vis, Register *reg, Text *txt, Filerange *range) {
 		Buffer buferr;
 		buffer_init(&buferr);
 
-		int status = vis_pipe(vis, range, false, (const char*[]){ VIS_CLIPBOARD, "--copy", NULL },
+		int status = vis_pipe(vis, range, (const char*[]){ VIS_CLIPBOARD, "--copy", NULL },
 			NULL, NULL, &buferr, read_buffer);
 
 		if (status != 0)