diff options
| author | Marc André Tanner <mat@brain-dump.org> | 2016-04-02 09:13:32 +0200 |
|---|---|---|
| committer | Marc André Tanner <mat@brain-dump.org> | 2016-04-03 21:38:04 +0200 |
| commit | d22d0cd31133c73366d65e38cddc3cf0f9a02918 (patch) | |
| tree | 75410b9c7a109636a0b486313ffb54f83c17fea0 /sam.c | |
| parent | 7bb9ba2fd76a307d2c61b791f2a1482529f30a6c (diff) | |
| download | vis-d22d0cd31133c73366d65e38cddc3cf0f9a02918.tar.gz vis-d22d0cd31133c73366d65e38cddc3cf0f9a02918.tar.xz | |
sam: restructure code to avoid useless goto
Diffstat (limited to 'sam.c')
| -rw-r--r-- | sam.c | 21 |
1 files changed, 6 insertions, 15 deletions
@@ -900,15 +900,11 @@ static bool cmd_files(Vis *vis, Win *win, Command *cmd, const char *argv[], File } static bool cmd_substitute(Vis *vis, Win *win, Command *cmd, const char *argv[], Filerange *range) { - bool ret = false; Buffer buf; buffer_init(&buf); - - if (!buffer_put0(&buf, "s") || !buffer_append0(&buf, argv[1])) - goto out; - - ret = cmd_filter(vis, win, cmd, (const char*[]){ argv[0], "sed", buf.data, NULL }, range); -out: + bool ret = false; + if (buffer_put0(&buf, "s") && buffer_append0(&buf, argv[1])) + ret = cmd_filter(vis, win, cmd, (const char*[]){ argv[0], "sed", buf.data, NULL }, range); buffer_release(&buf); return ret; } @@ -961,16 +957,11 @@ static bool cmd_write(Vis *vis, Win *win, Command *cmd, const char *argv[], File } static bool cmd_read(Vis *vis, Win *win, Command *cmd, const char *argv[], Filerange *range) { - - bool ret = false; Buffer buf; buffer_init(&buf); - - if (!buffer_put0(&buf, "cat ") || !buffer_append0(&buf, argv[1])) - goto out; - - ret = cmd_pipein(vis, win, cmd, (const char*[]){ argv[0], buf.data, NULL }, range); -out: + bool ret = false; + if (buffer_put0(&buf, "cat ") && buffer_append0(&buf, argv[1])) + ret = cmd_pipein(vis, win, cmd, (const char*[]){ argv[0], buf.data, NULL }, range); buffer_release(&buf); return ret; } |
