aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorRandy Palamar <palamar@ualberta.ca>2023-10-09 23:17:40 -0600
committerRandy Palamar <palamar@ualberta.ca>2023-10-10 07:00:06 -0600
commit1bfe132a81adddd33e078583f4198d8d8cb31d57 (patch)
treea3ec80ce12f5e09764f695fdf0d6b5ddda648cca
parentcbaa0d8cfe92a906d9869415833242961bb2b4ee (diff)
downloadvis-1bfe132a81adddd33e078583f4198d8d8cb31d57.tar.gz
vis-1bfe132a81adddd33e078583f4198d8d8cb31d57.tar.xz
revert c22b2c2 & 364d212
aka: "check for EOF before unsetting row, col & line cache in view_coord_get" "fix bug where visual-line selections after view were considered visible" These commits have created more bugs then they fix. Reverting them reintroduces #1074: Slave selection strangled by view cliff. Fixes #1143: Disappearing selection
-rw-r--r--CHANGELOG.md1
-rw-r--r--view.c3
2 files changed, 1 insertions, 3 deletions
diff --git a/CHANGELOG.md b/CHANGELOG.md
index e52e195..5967a31 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -6,7 +6,6 @@
- fix a ~ being considered a special character in path patterns (except at the start)
- improvements to and clean-up of vis-open
- add Selection:remove() to lua API
-- fix bug where visual-line selections after view were considered visible
- don't set `_FORTIFY_SOURCE` in configure
- update dockerfile to alpine 3.18
diff --git a/view.c b/view.c
index 5fa512b..2b06286 100644
--- a/view.c
+++ b/view.c
@@ -330,8 +330,7 @@ bool view_coord_get(View *view, size_t pos, Line **retline, int *retrow, int *re
size_t cur = view->start;
Line *line = view->topline;
- bool eof = view->end == text_size(view->text);
- if (pos < view->start || (pos >= view->end && !eof)) {
+ if (pos < view->start || pos > view->end) {
if (retline) *retline = NULL;
if (retrow) *retrow = -1;
if (retcol) *retcol = -1;